[wp-trac] [WordPress Trac] #26745: Awkward placement of more information plugin screen

[WordPress Trac]

#26745: Awkward placement of more information plugin screen
------------------------------+---------------------------------
 Reporter:  qBart             |       Owner:
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  3.9
Component:  Plugins           |     Version:  3.8
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  ui, administration
------------------------------+---------------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-testing needs-patch => has-patch commit
 * milestone:  Awaiting Review => 3.9


Comment:

 So, the plugin removes toolbar in the admin. We don't support that:
 #19685, #19766.

 However it uncovered a legitimate issue in our thickbox positioning code
 introduced in [26323].

 We use `$('body.admin-bar').length` to detect toolbar presence, and
 `jQuery('#wpadminbar').css('height')` to get its height, so
 `adminbar_height` ends up being NaN if `#wpadminbar` is not present.

 We should consistently use `#wpadminbar` in both places. See
 [attachment:26745.patch].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26745#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform