[wp-trac] [WordPress Trac] #27007: problem using wp_list_comments with 'per_page' without calling comments_template

[WordPress Trac]

#27007: problem using wp_list_comments with 'per_page' without calling
comments_template
--------------------------+------------------------------
 Reporter:  monotom       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Comments      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Description changed by SergeyBiryukov:

Old description:

> if you want to use wp_list_comments like this
>
>   wp_list_comments(
>     ['style'       => 'div',
>     'reply_text'  => 'kommentieren',
>     'avatar_size' => 73,
>     'per_page'    => 10000000 //or 0 or something
>     ])
>   )
>
> without using the comments_template method, there will be corrupted
> comment metadata links like this
>
> .../comment-page-#comment-15922
>
> ...in my opinion( and this core hack fixed it temporarily) it has to do
> with the methods Walker_Comment::comment and
> Walker_Comment::html5_comment which doesnt pass the $args to the
> get_comment_link method.
>
> So i think they should pass the args or if there are good reasons for
> this behavior the documentation have to be
> changed(http://codex.wordpress.org/Function_Reference/wp_list_comments).

New description:

 if you want to use wp_list_comments like this
 {{{
   wp_list_comments(
     ['style'       => 'div',
     'reply_text'  => 'kommentieren',
     'avatar_size' => 73,
     'per_page'    => 10000000 //or 0 or something
     ])
   )
 }}}
 without using the comments_template method, there will be corrupted
 comment metadata links like this

 .../comment-page-#comment-15922

 ...in my opinion( and this core hack fixed it temporarily) it has to do
 with the methods Walker_Comment::comment and Walker_Comment::html5_comment
 which doesnt pass the $args to the get_comment_link method.

 So i think they should pass the args or if there are good reasons for this
 behavior the documentation have to be
 changed(http://codex.wordpress.org/Function_Reference/wp_list_comments).

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27007#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform