[wp-trac] [WordPress Trac] #25391: Twenty Thirteen: Standardize And Update Genericons

WordPress Trac noreply at wordpress.org
Sun Feb 9 03:28:51 UTC 2014


#25391: Twenty Thirteen: Standardize And Update Genericons
------------------------------+-----------------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Future Release
Component:  Bundled Theme     |     Version:  3.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+-----------------------------
Changes (by celloexpressions):

 * keywords:  needs-patch => has-patch


Comment:

 Not sure if the full patch worked, so I broke out the functions.php
 changes as well. The other changes are to delete the `fonts/` directory
 and to add a `genericons/` directory containing the contents of
 [http://genericons.com/wp-content/themes/a8c/genericons/genericons.zip
 Genericons 3.0.3]. As with Twenty Fourteen, we should just keep the
 contents of that directory a complete copy of the Genericons package.

 None of the child themes in the .org repo touch anything related to
 Genericons, and these updates don't require changing anything in the theme
 itself. It's ''possible'' that this could break other custom
 implementations or plugins, but plugins need to load their own version of
 genericons anyway, which is likely updated with some frequency. And, as
 mentioned previously, this fix is the only way to ensure that there are
 minimal plugin/theme conflicts long-term.

 We should work out a plan for how to update genericons in Twenty Thirteen
 and Fourteen each time the themes are updated and there's a new version of
 Genericons.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25391#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list