[wp-trac] [WordPress Trac] #26823: wp_get_image_editor->multi_resize()
WordPress Trac
noreply at wordpress.org
Sat Feb 8 04:49:28 UTC 2014
#26823: wp_get_image_editor->multi_resize()
--------------------------+------------------
Reporter: pbearne | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.9
Component: Media | Version: 3.5
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
--------------------------+------------------
Comment (by DH-Shredder):
Attached [attachment: 26823.2.diff].
This contains the previous patch from @pbearne, plus:
* Updated documentation all around
* Whitespace rehabilitation (close to the patch from @wonderboymusic, with
additional style modifications)
* In editors, if a width/height is missing, set null rather than 0 for
missing values, to make it clear in code that we're not just setting a 0
width or height.
* Consolidated Tests
* Tests now unlink images after creation
* New test helper function to verify image dimensions (this works, but
it's possible this should be done outside of an editor, with PHP directly)
If it's immediately clear to a unit test wizard how we might do these
tests without the code duplication that exists, I will not complain in the
slightest -- since the only difference in most of these tests (between the
editors) is the class being called.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26823#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list