[wp-trac] [WordPress Trac] #26861: Too easy to delete a site in	Multisite
    WordPress Trac 
    noreply at wordpress.org
       
    Thu Feb  6 21:58:14 UTC 2014
    
    
  
#26861: Too easy to delete a site in Multisite
--------------------------------+------------------------------
 Reporter:  bradparbs           |       Owner:  bradparbs
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Networks and Sites  |     Version:
 Severity:  minor               |  Resolution:
 Keywords:  has-patch           |     Focuses:  ui, multisite
--------------------------------+------------------------------
Comment (by bradparbs):
 Replying to [comment:14 nacin]:
 > So, looks like the string is:
 >
 > > 'You are about to delete the site %s. This is a permanent and
 irrevocable. All pages, posts, comments, and other data will be deleted
 forever. There\'s no going back, please make sure this is something you
 want to do.
 >
 > Two quibbles:
 >
 >  * This string is long at more than 200 characters. If in a foreign
 language and URL encoded, it could come *really* close to the GET limit
 here. Can we make it so this stops getting passed via the URL? We can
 still use 'msg' if it is passed, but otherwise, we should be able to check
 that `'deleteblog' == $_GET['action2']` and then just print our message in
 sites.php. Not the original intent of this ticket, but I think it's
 necessary (and not difficult to do).
 >
 >  * The sentence has a comma splice. I'd make "There's no going back."
 its own sentence. And, since we're going to move this out of the query
 string, we might even be able to use these amazing things called paragraph
 tags. I'd put one right before "There's no going back."
 >
 > Brad, still interested in working on this?
 Great points - I'll throw together a patch for it later today. Thanks!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26861#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
    
    
More information about the wp-trac
mailing list