[wp-trac] [WordPress Trac] #26823: wp_get_image_editor->multi_resize()

[WordPress Trac]

#26823: wp_get_image_editor->multi_resize()
----------------------------------------+------------------------------
 Reporter:  pbearne                     |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Media                       |     Version:  3.5
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:
----------------------------------------+------------------------------
Changes (by nacin):

 * keywords:  has-patch good-first-bug => good-first-bug needs-patch


Comment:

 That patch will work fine if 'width' or 'height' are set to null, but it
 will throw a notice if 'width' or 'height' are omitted entirely. So, we
 should either enforce that 'width' and 'height' are to be passed (even if
 as null), or we should work to avoid a notice, thus allowing 'width' or
 'height' to be omitted in lieu of being passed as null.

 Unit tests would be great either way to ensure A) it works and B) no
 notice is thrown.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26823#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform