[wp-trac] [WordPress Trac] #26985: Use network_site_url in includes_url

WordPress Trac noreply at wordpress.org
Sat Feb 1 19:29:18 UTC 2014


#26985: Use network_site_url in includes_url
-------------------------+------------------------------
 Reporter:  nofearinc    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Permalinks   |     Version:  3.6
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  multisite
-------------------------+------------------------------

Comment (by nofearinc):

 Thanks nacin, I haven't tested that in an environment with domain mapping
 configured.

 The two things just bothering me are:

 1. The `$baseurl` set for the
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 editor.php#L193 wp-editor] and then loaded in a few places
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 editor.php#L760 like this] seems a bit tough for me to export to CDN (or
 generally problematic overall for the admin area)
 2. Isn't `network_site_url` supposed to behave normally anyway? Just
 curious if it's another vector to consider if being used in other
 functions for fetching the correct URL (or providing another helper that
 respects mapped domains)?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26985#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list