[wp-trac] [WordPress Trac] #30788: Media library views: inconsistent behaviour with mime type groups

[WordPress Trac]

#30788: Media library views: inconsistent behaviour with mime type groups
--------------------------+------------------------------
 Reporter:  mdgl          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |     Focuses:  javascript
--------------------------+------------------------------

Comment (by mdgl):

 I did a lot more testing and code review on this today and am now much
 more confident in the (updated) patch.

 It turns out that `wp_match_mime_types()` is also used to match what are
 effectively file names and types by function `wp_mime_type_icon()` so I
 have added back the third (and un-anchored) regular expression to retain
 backwards compatibility.  The existing code in `wp_mime_type_icon()` looks
 a bit iffy to me and likely to return unexpected results in some
 situations, but that should be the subject of another ticket.

 I have not addressed the issue of inconsistencies in labelling and
 numbering between the PHP and JavaScript views. Again, those are perhaps
 better dealt with on a separate ticket.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30788#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform