[wp-trac] [WordPress Trac] #30770: Twenty Fifteen: Theme Review: Stylesheets and Scripts
WordPress Trac
noreply at wordpress.org
Wed Dec 31 12:42:57 UTC 2014
#30770: Twenty Fifteen: Theme Review: Stylesheets and Scripts
---------------------------+-----------------------
Reporter: emiluzelac | Owner:
Type: defect (bug) | Status: reopened
Priority: normal | Milestone:
Component: Bundled Theme | Version: 4.1
Severity: normal | Resolution:
Keywords: | Focuses:
---------------------------+-----------------------
Changes (by philiparthurmoore):
* status: closed => reopened
* resolution: wontfix =>
Comment:
I have absolutely no idea what I was going on about two weeks ago. I just
ran a bunch of no JS tests with a different theme that I'm working on and
using `wp_enqueue_scripts` was totally fine. The only real difference
between `wp_head` and `wp_enqueue_scripts` was that the no JS detection
came under the page title when `wp_enqueue_scripts` was used.
Chip's intent was good I think, given the discussion, but I tend to think
that we could even use `wp_enqueue_scripts` with Chip's approach just
fine. So this:
{{{
add_action( 'wp_head', 'twentyfifteen_enqueue_js_fix', 0 );
}}}
Becomes this:
{{{
add_action( 'wp_enqueue_scripts', 'twentyfifteen_enqueue_js_fix' );
}}}
If I could go back in time I'd probably kick myself, but here we are.
Sorry for the stubbornness earlier.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30770#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list