[wp-trac] [WordPress Trac] #6481: Fancy permalinks should be enabled on new sites
WordPress Trac
noreply at wordpress.org
Mon Dec 29 16:09:30 UTC 2014
#6481: Fancy permalinks should be enabled on new sites
------------------------------------+------------------
Reporter: Denis-de-Bernardy | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.2
Component: Permalinks | Version: 2.7
Severity: minor | Resolution:
Keywords: has-patch dev-feedback | Focuses:
------------------------------------+------------------
Comment (by nacin):
valendesigns' patch moves the logic into wp_install_defaults(), which
actually highlights an issue I was going to point out. If
wp_install_defaults() is overridden and no defaults are actually created,
then these would fail. But there's no reason we need to do that.
When `get_permalink( 1 )` returns `false`, we could just as easily hit
/some-random-404-page/ and as long as we get back a response from the
WordPress install, then we know rewrites work. That could be as easy as
looking for a `X-Pingback` header. I don't think we ''need'' to account
for this but I'd like to see if we don't need make assumptions that any
default data is in place, or even that its ID is 1.
Also, I don't think this code belongs in wp_install_defaults(). It's not
default content; that function can be overridden; and there's really no
harm in leaving it in its own function.
Really happy to see this on track for inclusion.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/6481#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list