[wp-trac] [WordPress Trac] #6481: Fancy permalinks should be enabled on new sites
WordPress Trac
noreply at wordpress.org
Sat Dec 27 02:41:10 UTC 2014
#6481: Fancy permalinks should be enabled on new sites
-------------------------------+-----------------------------
Reporter: Denis-de-Bernardy | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Permalinks | Version: 2.7
Severity: minor | Resolution:
Keywords: has-patch | Focuses:
-------------------------------+-----------------------------
Comment (by ericlewis):
In attachment:6481.3.diff, I iterated on attachment:wp-
admin_includes_upgrade.php.diff.
* I believe pluggable functions are considered an anti-pattern at this
point (correct me if I'm wrong) because of the headache in backwards
compatibility they proffer, and if we want to offer flexibility in our API
we can do it in more forward-thinking ways (e.g. hooks API).
* Instead of setting the permalink structure here, let's set it at the
options defaults, which delightfully brings together a fork of
functionality between multisite and single site.
* For now, keep this smoke testing separate from multisite. Preferably
single and multi share this functionality, but for reasons I haven't dug
into yet, the smoke test failed for a fresh multisite.
* General code clean-up - `wp_install_verify_permalink_structure()` is a
single-responsibility function to smoke test the "Hello World" HTTP
response code, use `wp_remote_head()` instead of `wp_remote_request`, etc.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/6481#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list