[wp-trac] [WordPress Trac] #30679: Clicking "Restore this Revision" publishes immediately

[WordPress Trac]

#30679: Clicking "Restore this Revision" publishes immediately
---------------------------+------------------------------
 Reporter:  paulschreiber  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Revisions      |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+------------------------------

Comment (by adamsilverstein):

 'Restore this Revision' is actually pretty safe, you can always restore
 the previous revision to undo the restore action!

 I think '''''restoring is the primary action''''' people want to take when
 visiting the revisions screen (many people head there to undo a published
 mistake), and the diff view shows the changes, helping the user pick the
 correct revision to restore (although I'd prefer a preview or customizer
 integration).


 Replying to [comment:5 jlambe]:
 > 'Edit this revision' sounds better and clear. But as how this should be
 shown visually I do not know. For me, the 'Edit this revision' button
 should get the style of a primary button and the actual button could align
 on the left but only simple text (maybe underlined) in order to show it as
 secondary action.
 >
 > The fact that 'Edit this revision' becomes visually the primary button
 gives the user the "safety" of not publishing its revision and allows him
 to perhaps edit it before publishing. But we don't forget confident users
 which want to publish immediately the revision by providing the actual
 button but less present visually.
 >
 > Not sure if my explanations are clear :)
 >
 > Replying to [comment:4 adamsilverstein]:
 > > Maybe an 'Edit this Revision' button next to 'Restore this Revision'?
 > >
 > > Replying to [comment:3 adamsilverstein]:
 > > > Julien,
 > > >
 > > > Thanks for your offer of help!
 > > >
 > > > I agree, this would be a great feature to have. #23314 is very close
 to this ticket, almost a duplicate? A good fix would solve both cases.
 > > >
 > > > There are actually several related tickets, including #23314 and
 #20299 - all these tickets would benefit from something missing from core
 - the revisioning of post meta (see #20564) - without that feature, the
 data stored for each revision is limited to the primary editor fields
 (title, content, excerpt, etc.). We got the hooks needed for this feature
 into 4.1, leveraged by the plugin linked from the ticket.
 > > >
 > > > If the button were to restore the content only to the editor and not
 publish the restored revision, how would you change the button text to
 indicate that action? 'Restore revision data to editor' ? (thats a
 mouthful!)
 > > >
 > > >
 > > > Replying to [comment:2 jlambe]:
 > > > > This could be a great feature. I'm having a situation where I need
 to maintain documentation pages (saved as WordPress pages post type). One
 revision is published but now we need to update its content with new
 features for example.
 > > > >
 > > > > So start typing and adding new lines in the editor of the current
 published revision. What would be great is a "Save as a revision" kind of
 button which will save the new changes but without publishing them. Then
 allow a user to logout and come back anytime edit the revision and when
 everything seems good, have the choice to publish it.
 > > > >
 > > > > Like @paulshriber explains, it's not clear what the "Restore this
 revision" button is doing. As a end-user, I expected it to load its
 content inside the editor, allow me to edit it and perhaps publish it
 immediately right after.
 > > > >
 > > > > Really looking into this feature and I can help too ;)
 > > > >
 > > > > Was looking at older tickets for this component and it looks like
 this could be related with this ticket:
 [https://core.trac.wordpress.org/ticket/23314]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30679#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform