[wp-trac] [WordPress Trac] #29841: Don't replace non embeddable URLs with a loading placeholder

[WordPress Trac]

#29841: Don't replace non embeddable URLs with a loading placeholder
-------------------------------------+-------------------------
 Reporter:  avryl                    |       Owner:  avryl
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.2
Component:  TinyMCE                  |     Version:  4.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+-------------------------
Changes (by avryl):

 * keywords:   => has-patch needs-testing
 * milestone:  Future Release => 4.2


Comment:

 Initially I wanted to approach this differently by not setting a
 placeholder, but that wouldn't be ideal for shortcodes (ideally the user
 should never see the shortcode).

 Instead it would be better check the url with the regexes of the
 providers. So this patch converts them for JS and adds an additional check
 before replacing with a loading placeholder. I'm not a regex expert, so
 this should definitely be checked/tested.

 This patch will also set the cursor to the end of the view if the cursor
 is within the view so you can continue typing.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29841#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform