[wp-trac] [WordPress Trac] #30753: wp_parse_str() improperly casts boolean querystring values as strings

[WordPress Trac]

#30753: wp_parse_str() improperly casts boolean querystring values as strings
--------------------------+------------------------------
 Reporter:  r-a-y         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Formatting    |     Version:  2.2.1
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Changes (by nacin):

 * version:  4.1 => 2.2.1


Comment:

 Yeah, I don't think we should change this. But it's good to have
 documented here in a ticket.

 I'd prefer to discourage query string usage. At the same time I'd also
 like to not break it. And this will surely break something that someone is
 doing somewhere. wp_parse_args() is an ubiquitous, low-level function.

 Thanks for including a unit test! Perhaps we should instead add a unit
 test that expects this to produce the string 'false', and link to this
 ticket, in order to enforce the design decision here. That way it's
 documented in an even better way.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30753#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform