[wp-trac] [WordPress Trac] #30827: wp_can_install_language_pack(): Direct access to $upgrader->fs_connect() can produce undefined index notices

[WordPress Trac]

#30827: wp_can_install_language_pack(): Direct access to $upgrader->fs_connect()
can produce undefined index notices
----------------------------+-----------------------------
 Reporter:  ocean90         |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  low             |  Milestone:  Awaiting Review
Component:  Filesystem API  |    Version:  4.0
 Severity:  minor           |   Keywords:  has-patch
  Focuses:                  |
----------------------------+-----------------------------
 Example: `Notice: Undefined index: fs_no_content_dir in /src/wp-
 admin/includes/class-wp-upgrader.php on line 182`

 That's because the init() method isn't called here, which sets up the
 strings. We should either do `$upgrader->init()` or
 `$upgrader->generic_strings()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30827>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform