[wp-trac] [WordPress Trac] #30808: WordPress 4.1 comments are not loading when you sign-in to the site

[WordPress Trac]

#30808: WordPress 4.1 comments are not loading when you sign-in to the site
--------------------------+----------------------
 Reporter:  writegnj      |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Comments      |     Version:  4.1
 Severity:  normal        |  Resolution:  invalid
 Keywords:                |     Focuses:
--------------------------+----------------------
Changes (by boonebgorges):

 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 writegnj - Thanks very much for following up. As I suspected, this is due
 to the changes in #19623.

 At https://plugins.trac.wordpress.org/browser/view-own-posts-media-
 only/trunk/includes/class-view-own-posts-media-only.php#L54 the plugin
 adds a filter to comment queries (when the admin has toggled the setting
 in question) that will prevent users from seeing others' comments. The way
 comments were previously queried on the front end of WP meant that this
 filter was *not* run for that query. My interpretation of the code is that
 the way it's working now is the way it was originally intended to work -
 WP 4.1 fixed it. You should be able to fix things by toggling the plugin's
 "comments" setting; the plugin author should be able to restore the old
 behavior by wrapping the filter in an `is_admin()` check or some other
 appropriate check.

 As this appears to be a case where the filter is working as intended, I'm
 going to close this ticket as invalid. If other cases arise where plugins
 are doing similar things after 4.1, please feel free to reopen with
 details and we can reassess.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30808#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform