[wp-trac] [WordPress Trac] #30799: Scrutinizer in 4.2

[WordPress Trac]

#30799: Scrutinizer in 4.2
----------------------------+--------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  4.2
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+--------------------

Comment (by wonderboymusic):

 In [changeset:"30980"]:
 {{{
 #!CommitTicketReference repository="" revision="30980"
 In `wp_import_handle_upload()`:

 `$file` was essentially getting declared/overwritten 3 times. In lieu of
 this, return an array containing the error immediately instead of doing a
 short-circuit array key assignment on error. Rename the local variable to
 `$upload` and use its properties instead of creating 3 new local vars, one
 of which stomped the array.

 See #30799.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30799#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform