[wp-trac] [WordPress Trac] #30770: Twenty Fifteen: Theme Review: Stylesheets and Scripts

WordPress Trac noreply at wordpress.org
Fri Dec 19 14:18:27 UTC 2014


#30770: Twenty Fifteen: Theme Review: Stylesheets and Scripts
---------------------------+----------------------
 Reporter:  emiluzelac     |       Owner:
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Bundled Theme  |     Version:  4.1
 Severity:  normal         |  Resolution:  wontfix
 Keywords:                 |     Focuses:
---------------------------+----------------------

Comment (by cais):

 Replying to [comment:8 emiluzelac]:
 > Not really sure what is the best way, you can see:
 https://themes.trac.wordpress.org/ticket/20079#comment:3 for example.
 >
 > This is not a question how to improve or do this better, guidelines
 should apply to all themes equally and if it does not, it will came back
 on us the reviewers :)

 I would have to agree with this, especially with the reference to another
 "Automattic" theme using the same approach being happy to make the changes
 to the code that reflects current theme review team requirements and
 recommendations.

 It is also very important that bundled themes follow these requirements
 and recommendations as many theme developers, new and old, will often use
 the bundled theme's code as a basis for their own works applying the same
 methods and constructs with the belief, "If Twenty X uses it, then it must
 be perfectly fine for me to use it too"

 I can accept (although not like at all) a bundled theme being pushed
 through the queues ahead of all others (it is a WordPress repository after
 all) but I also believe it is still vitally important for the theme review
 team and the bundled themes authors to work together to find the best go
 forward approach; and, ignoring a guideline because you don't think its
 appropriate is not the best way of doing it.

 Exceptions are fine, and there will always be considerations for them ...
 but wouldn't it be better to discuss them before rather than after the
 fact?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30770#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list