[wp-trac] [WordPress Trac] #30753: wp_parse_str() improperly casts boolean querystring values as strings

[WordPress Trac]

#30753: wp_parse_str() improperly casts boolean querystring values as strings
--------------------------+------------------------------
 Reporter:  r-a-y         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Formatting    |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by dd32):

 Although the change makes sense on the surface, what you're really doing
 here is literally passing a string value of `'false'`, which is a
 completely acceptable string to be used here.

 In many themes and even some places in core in the past, we've used
 `bool_attribute=0` to designate false-y.

 This change unfortunately has the downside that it could cause a bug in
 anything that expects the string "false" as a value.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30753#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform