[wp-trac] [WordPress Trac] #30724: Twenty Fifteen: Unnecessary use of esc_html()

[WordPress Trac]

#30724: Twenty Fifteen: Unnecessary use of esc_html()
------------------------------------------+-----------------------
 Reporter:  ocean90                       |       Owner:  ocean90
     Type:  defect (bug)                  |      Status:  accepted
 Priority:  high                          |   Milestone:  4.1
Component:  Bundled Theme                 |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch commit fixed-major  |     Focuses:
------------------------------------------+-----------------------

Comment (by adamsilverstein):

 Thanks for the clarification, much appreciated.

 Replying to [comment:10 ocean90]:
 > Replying to [comment:8 adamsilverstein]:
 > > @ocean90: I'm curious about your removal of escaping from translations
 - can you briefly explain/point me to the the logic?
 >
 > That's simple. If we don't trust translations anymore we should do it
 directly in the function. `function __() { return esc_html(…`.
 >
 > Replying to [comment:9 TomasM]:
 > > I follow the development of _s and default WP themes to make my themes
 better and recently in Twenty Fifteen and _s there was escaping promoted.
 Now, when I applied those changes to my theme I will have to revert :-/
 >
 > That over-escaping seems to come from .com which is something I (and
 nacin, I talked with him before this ticket) don't want to support,
 especially not for a default theme where we have a type of review process
 for translations.
 >
 > > Is there any harm for having escaping in place?
 > No harm.
 >
 > [[BR]]
 >
 > BTW: Twenty Fifteen wasn't even consistent with this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30724#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform