[wp-trac] [WordPress Trac] #30409: Twenty Fifteen: HTML characters in the color scheme CSS are escaped.
WordPress Trac
noreply at wordpress.org
Tue Dec 16 10:19:34 UTC 2014
#30409: Twenty Fifteen: HTML characters in the color scheme CSS are escaped.
-------------------------------------+--------------------------
Reporter: iamtakashi | Owner: iandstewart
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.1
Component: Bundled Theme | Version: trunk
Severity: blocker | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+--------------------------
Comment (by nacin):
OK, let's get the latest patch in. Exception:
* The change to src/wp-includes/js/customize-preview.js should be done in
its own commit, preferably its own quick ticket.
Things I still don't like, and would consider adjustments to:
* The editable colors being 0, 1, and 4, rather than 0, 1, and 2. This is
far too magical and I have no idea what it means.
* Using numeric arrays for color definitions when it's really important
for others to understand what is what, but associative arrays internally
when it doesn't matter as much.
* Lots of really complicated stuff in a default theme. Lots of
opportunities to simplify.
And while I am here, things that are definitely fixable:
* Far, far too much unnecessary use of esc_html(), especially on
translated strings.
* Lots of things are pluggable that shouldn't be.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30409#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list