[wp-trac] [WordPress Trac] #30220: Make single responsibility function for outputting Revisions JS templates

WordPress Trac noreply at wordpress.org
Mon Dec 15 09:39:14 UTC 2014


#30220: Make single responsibility function for outputting Revisions JS templates
------------------------------+-----------------------------
 Reporter:  ericlewis         |       Owner:  wonderboymusic
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  4.1
Component:  Revisions         |     Version:  3.6
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  javascript
------------------------------+-----------------------------

Comment (by nacin):

 So, I like using $post here, or at least not making it a function argument
 (as in, `$post = get_post()` would be fine), because it's only actually
 used to set a disabled attribute on a button. This should really be set in
 JS based on the model. It would be lovely to get rid of any kind of state
 in this function.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30220#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list