[wp-trac] [WordPress Trac] #29856: Setting default quality doesn't always work

WordPress Trac noreply at wordpress.org
Thu Dec 11 23:17:11 UTC 2014


#29856: Setting default quality doesn't always work
-----------------------------------------+-----------------------------
 Reporter:  markoheijnen                 |       Owner:  SergeyBiryukov
     Type:  defect (bug)                 |      Status:  closed
 Priority:  normal                       |   Milestone:  4.1
Component:  Media                        |     Version:  4.0
 Severity:  normal                       |  Resolution:  fixed
 Keywords:  has-patch reporter-feedback  |     Focuses:
-----------------------------------------+-----------------------------

Comment (by DH-Shredder):

 Was going through the unit tests for this, and found several edge cases
 that needed a bit of further testing.

 While doing so, noticed that it's not clear in docs that if you
 instantiate an editor, then either quality filter is applied, it does not
 affect the quality of any further images saved by that editor (unless
 `set_quality` is directly called with a `null` parameter).

 Would be great to get the docs changes in 4.1 if it's still an option.
 Unit tests, of course, also help, but can wait if it's too much for the
 milestone.

 The [attachment:29856.docs_test.diff attached patch] contains both
 changes, but I can split them out if it's helpful.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29856#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list