[wp-trac] [WordPress Trac] #29769: Let's give users a friendly reminder to backup before they upgrade their network as well.

WordPress Trac noreply at wordpress.org
Wed Dec 10 22:59:56 UTC 2014


#29769: Let's give users a friendly reminder to backup before they upgrade their
network as well.
--------------------------+--------------------------------------------
 Reporter:  NikV          |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Text Changes  |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, administration, multisite
--------------------------+--------------------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:2 chriscct7]:
 > HTML shouldn't be inside a localized string as it doesn't need to be
 translated. See HTML section on
 http://codex.wordpress.org/I18n_for_WordPress_Developers

 [attachment:upgrade-revised.php.diff] is actually perfectly fine from a
 translator's point of view, and appears to using an [source:tags/4.0.1/src
 /wp-admin/update-core.php#L165 existing string]. Codex links can be
 translated as well, so that section does not apply here.

 My concern with the patch is that database upgrades are generally safe and
 not intensive, so the additional reminder is probably not needed.

 See comment:5:ticket:7965, which suggests removing the extra database
 update step in single site.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29769#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list