[wp-trac] [WordPress Trac] #30608: Media: toolbar not restored after leaving iframe-based content

[WordPress Trac]

#30608: Media: toolbar not restored after leaving iframe-based content
--------------------------+-----------------------------
 Reporter:  mcsf          |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Media         |    Version:
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Observable on WPCOM, could affect sites that extend the Media Manager.
 Steps to reproduce:

 - Go to /wp-admin/post-new.php
 - Select Insert Media
 - Once the Media modal loads, select, if you have any, a view from the
 sidebar that loads an iframe. Such a view will replace the whole content +
 toolbar area. You might see a fake toolbar here if the iframe imitates it.
 - Again from the sidebar, select, if you have any, a custom view (i.e.,
 not Insert Media or Create Gallery) that does not load an iframe.

 Expected: the bottom toolbar, containing an Insert button, should be
 visible.
 Observed: the toolbar “disappears” when going from the iframe-based view
 to the non-iframe-based view.

 I used quotes because the toolbar isn’t actually disappearing—it’s
 actually not reappearing after we leave the iframe.

 I'm attaching a working patch for this.

 cc @dd32 @azaozz @pento

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30608>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform