[wp-trac] [WordPress Trac] #30299: Inconsistent custom-background Body Class Behavior

[WordPress Trac]

#30299: Inconsistent custom-background Body Class Behavior
-------------------------------+------------------------------
 Reporter:  philiparthurmoore  |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Customize          |     Version:
 Severity:  normal             |  Resolution:
 Keywords:                     |     Focuses:
-------------------------------+------------------------------
Changes (by boonebgorges):

 * version:  trunk =>


Comment:

 In part, this seems like a problem in semantics. You're interpreting
 "custom" to mean "something other than the default", while the current
 meaning of "custom" in core is "having been changed by the user". IMO,
 there's some value in the latter intepretation: if an admin has explicitly
 chosen to set a value for the background color, then it shouldn't matter
 what that color is. Presumably, you are then using the '.custom-
 background' class (or the lack thereof) to do some style overrides, and I
 would argue that you ought not to be doing these overrides if the admin
 has explicitly declared the color.

 In any case, it appears that this is not a regression from 4.0, so I'm
 going to remove the 'Version' label to clear some of our pre-4.1 release
 reports. Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30299#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform