[wp-trac] [WordPress Trac] #21483: Refactor Customizer Upload, Image, and Background Image controls to leverage the media library/modal

[WordPress Trac]

#21483: Refactor Customizer Upload, Image, and Background Image controls to
leverage the media library/modal
-------------------------------------+-----------------------------
 Reporter:  jjonesftw                |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  4.1
Component:  Customize                |     Version:  3.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, javascript
-------------------------------------+-----------------------------

Comment (by celloexpressions):

 I'm okay with [attachment:21483.10.diff], but I have the following mostly
 design-related concerns:
 - Can we remove the border around the preview if it's not empty? Looks
 pretty bad for non-images, as there's no padding around the icon, and it
 just seems unnecessary.
 - Also not liking the 2px border radius on images and the container. If we
 want to be consistent I'd remove that for headers too.
 - Could we possibly have fewer container divs around the previews? Looks
 like there are four levels of nested divs, and we should remove at least
 `div.current` and `div.container` since they're meaningless name-wise. We
 don't need all of that CSS here either - we should not set a min-height
 for these, for example. Maybe start by having fewer containers, then clean
 up unneeded or less attractive styles. We can tweak the headers UI design
 too, and I think it could definitely use updating here.
 - I really don't think default/remove should have the same visual
 hierarchy as change/select. A button and a link would make way more sense
 than two buttons, although I don't have a preference for left vs. right
 aligned (and this goes for headers too).

 The functional bits here are fine. To clarify for anyone following along,
 audio/video are still supported, they just won't have interactive previews
 (yet).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21483#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform