[wp-trac] [WordPress Trac] #29392: Notice on install screen.
WordPress Trac
noreply at wordpress.org
Wed Aug 27 16:12:47 UTC 2014
#29392: Notice on install screen.
--------------------------+--------------------
Reporter: markoheijnen | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.0
Component: General | Version: trunk
Severity: minor | Resolution:
Keywords: has-patch | Focuses:
--------------------------+--------------------
Comment (by stephdau):
Edge case or not, I'd ass the test you have in your patch. You could also
replace `isset()` by `empty()`, and the test would also stop there whether
not set or empty. Regardless, I think we're better off with one edge case
test than missing it when needed (since the perf cost is trivial). :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29392#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list