[wp-trac] [WordPress Trac] #29305: Merge two strings

WordPress Trac noreply at wordpress.org
Tue Aug 26 18:43:28 UTC 2014


#29305: Merge two strings
-------------------------+------------------------------
 Reporter:  pavelevap    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  I18N         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:
-------------------------+------------------------------
Changes (by stephdau):

 * type:  defect (bug) => enhancement


Comment:

 There are only 3 instances of that string (without the ending dot) in the
 sourcecode.
  * The ones you tended to in attachment:29305.patch
  * one instance in wp-admin/options-reading.php

 The latter happens to be in a legacy part of the code that is no longer
 the default.
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/options-
 reading.php?rev=29628#L148
 {{{
 /**
 154              * Enable the legacy 'Site Visibility' privacy options.
 155              *
 156              * By default the privacy options form displays a single
 checkbox to 'discourage' search
 157              * engines from indexing the site. Hooking to this action
 serves a dual purpose:
 158              * 1. Disable the single checkbox in favor of a multiple-
 choice list of radio buttons.
 159              * 2. Open the door to adding additional radio button
 choices to the list.
 160              *
 161              * Hooking to this action also converts the 'Search Engine
 Visibility' heading to the more
 162              * open-ended 'Site Visibility' heading.
 163              *
 164              * @since 2.1.0
 165              */
 }}}

 Maybe we should consider adding an ending dot to the old one instead, and
 have proper English grammar in all 3 places.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29305#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list