[wp-trac] [WordPress Trac] #29230: When installing a plugin/theme, translations fail to install

WordPress Trac noreply at wordpress.org
Tue Aug 26 08:06:07 UTC 2014


#29230: When installing a plugin/theme, translations fail to install
------------------------------+--------------------
 Reporter:  netweb            |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.0
Component:  Upgrade/Install   |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------
Changes (by dd32):

 * keywords:  has-patch => has-patch commit


Comment:

 Upon initial review, this change looks okay to me, although it's really a
 brute force fix, but one that will work for the foreseeable future (I
 think).

 This (upgrader_source_selection) is probably something that shouldn't have
 been a filter, but rather, a callback parameter passed into the update
 methods instead, so that it only applies to the update instance in
 question. Out of  scope for 4.0 though, so this patch seems good to go.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29230#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list