[wp-trac] [WordPress Trac] #23560: Keyboard Accessibility of Add Media Panel

[WordPress Trac]

#23560: Keyboard Accessibility of Add Media Panel
----------------------------+----------------------------------------
 Reporter:  grahamarmfield  |       Owner:
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  4.0
Component:  Media           |     Version:  3.5.1
 Severity:  normal          |  Resolution:  fixed
 Keywords:                  |     Focuses:  accessibility, javascript
----------------------------+----------------------------------------

Comment (by gcorne):

 [attachment:23560.29.diff 23560.29.diff] addresses the following:

 1. Adjusts the {{{focus}}} method to target the menu for the current modal
 2. After discussing with @nacin and @helen, we decided not to focus the
 close link by default because it is visually distracting when not
 navigating via keyboard. Instead, focus is placed on the modal.
 3. Refactors the {{{FocusManager}}} so that the method names and the
 functionality matches more closely with how it currently works. The
 changes in 4.0 to the {{{FocusManager}}} change the purpose of the focus
 manager entirely — instead of being a way to save and restore focus state,
 the new {{{FocusManager}}} is about constraining keyboard navigation via
 the tab key to inside the modal. I don't think that it is very likely that
 3rd-party devs are using the constructor, but the potential BC break did
 cross my mind.

 I also have seen an intermittent issue when on the Upload tab in FF where
 the constrained tabbing is too constrained, which makes it impossible to
 keyboard navigate via tab to the modal menu. Not sure why/how that
 happens, but my best guess is that somehow the order of the FF focus ring
 doesn't match the order of the tabbable elements as returned by jQuery.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23560#comment:132>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform