[wp-trac] [WordPress Trac] #29236: install_plugins_tabs cannot filter the "upload" tab anymore

[WordPress Trac]

#29236: install_plugins_tabs cannot filter the "upload" tab anymore
--------------------------+--------------------
 Reporter:  juliobox      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.0
Component:  Plugins       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by mpatek):

 Doesn't work for me, either. I think this patch is overriding the global
 $tabs defined in WP_Plugin_Install_List_Table.

 It looks like the 'upload' tab is currently contained in $nonmenu_tabs
 which is filtered by  'install_plugins_nonmenu_tabs'.

 So, maybe what we want to do here is to test whether upload still exists
 after being filtered by 'install_plugins_nonmenu_tabs'? Or check for it in
 the combination of menu+nonmenu tabs?

 Or maybe we could give the list table a method that would enable us to
 know which tabs it supports?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29236#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform