[wp-trac] [WordPress Trac] #29135: Theme Customizer gives wrong UI actions on iOS
WordPress Trac
noreply at wordpress.org
Sat Aug 23 23:26:03 UTC 2014
#29135: Theme Customizer gives wrong UI actions on iOS
-------------------------------------+--------------------
Reporter: Ipstenu | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.0
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+--------------------
Changes (by celloexpressions):
* keywords: needs-patch => has-patch needs-testing
Comment:
When I implemented this initially, it made sense for each panel to have
its own back button. But we can just have them all use a universal one
fairly easily while maintaining keyboard accessibility, since they're
auto-focused anyway.
[attachment:29135.diff] switches to using a single back button for all
panels, and locates the button in the header where it shouldn't run into
the iOS bug that we're running into with this ticket. I don't have an iOS
device to test on, but this should work. It's more churn than I'd like at
this point, but the only other option is probably to implement touch
gestures (swiping right to exit a panel), which is way to enhancementy to
happen now.
`accordion.js` is really awful, but this change fits right in there. Once
we eventually move the panel-switching JS to a more structured
environment, it might make more sense to have separate buttons for each
panel, but I'm okay with switching to one for now.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29135#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list