[wp-trac] [WordPress Trac] #29286: Plugin cards: make whole card open info modal

WordPress Trac noreply at wordpress.org
Fri Aug 22 01:32:29 UTC 2014


#29286: Plugin cards: make whole card open info modal
-------------------------------------------------+--------------------
 Reporter:  stephdau                             |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  4.0
Component:  Plugins                              |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing 2nd-opinion  |     Focuses:
-------------------------------------------------+--------------------
Changes (by nacin):

 * keywords:  has-patch needs-testing => has-patch needs-testing 2nd-opinion
 * milestone:  Awaiting Review => 4.0


Comment:

 I'm a nervous clicker so helen asked me to take a look at this. I was
 playing around with this earlier today and I don't dislike it... But it
 also means I can't select anything. Bailing if
 `document.getSelection().type === 'Range'` makes this feel a lot better
 and then I'm a bit more inclined to go with it.

 Moving to 4.0 for review. Could use additional opinions.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29286#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list