[wp-trac] [WordPress Trac] #23560: Keyboard Accessibility of Add Media Panel

[WordPress Trac]

#23560: Keyboard Accessibility of Add Media Panel
-------------------------------------+-------------------------------------
 Reporter:  grahamarmfield           |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.0
Component:  Media                    |     Version:  3.5.1
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing needs-     |     Focuses:  accessibility,
  patch                              |  javascript
-------------------------------------+-------------------------------------
Changes (by wonderboymusic):

 * keywords:  needs-testing has-patch dev-feedback => needs-testing needs-
     patch
 * focuses:  accessibility => accessibility, javascript


Comment:

 This ticket has way too much going on, I almost blacked out several times
 reading it.

 We should do one or both of the following:
 * New patches should only pertain to one issue at a time.
 * New tickets should be created for individual items.

 Most of the patches uploaded are too far-reaching and lose sight of the
 role they are playing. Most of the commits I have done today were cleaning
 up code that came in off the streets and ended up in places it shouldn't
 have been.

 I'm down to keep slogging through this, but we should take it slow so we
 can test everything properly.

 NOTE:
 * If you are in a class that does not extend `Backbone.View`, there is
 little to no chance it should contain a jQuery selector
 * If you are in class that DOES extend `Backbone.View`, your selectors
 should probably look like:
 `this.$( '.yep' )`

 As we tackle more issues, it should also be clear what is happening as
 pertains to Grid AND Modal.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23560#comment:126>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform