[wp-trac] [WordPress Trac] #28883: Plugin details lightbox screwing up plugins with large names in 4.0

[WordPress Trac]

#28883: Plugin details lightbox screwing up plugins with large names in 4.0
-------------------------------------+--------------------
 Reporter:  hardeepasrani            |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.0
Component:  Plugins                  |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui
-------------------------------------+--------------------

Comment (by stephdau):

 The patch needed to be refreshed, based on the changes committed in
 r29474.

 I've looked at the gist of it, and was able to get to what I think is a
 decent handling in attachment:28883.7.diff, but as you can see in the last
 screenshot of https://cloudup.com/cN4DcBMqDi5, I've noticed that our
 banner handling is sketchy at smaller width (but tall) because we decide
 to switch to the other mode based on the screen height.

 attachment:28883.7-widthonly.diff is the same as 28883.7.diff, but by
 detecting small-screen mode based on screen width height<771px, like the
 rest, not height<500px. Any narrow screen can benefit from the smaller
 banner. This could also be its own ticket, but I figured I'd give you the
 option to do either.

 See https://cloudup.com/czeF7wzz-07

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28883#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform