[wp-trac] [WordPress Trac] #29048: Twenty Thirteen: editor styles for audio format cause issues in wpviews

[WordPress Trac]

#29048: Twenty Thirteen: editor styles for audio format cause issues in wpviews
------------------------------+-----------------------
 Reporter:  celloexpressions  |       Owner:  azaozz
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  4.0
Component:  TinyMCE           |     Version:  trunk
 Severity:  major             |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+-----------------------
Changes (by celloexpressions):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Twenty Fourteen makes several changes to audio and video players beyond
 the colors, including using Genericons for the icons, for example. I don't
 think we should just throw out styles that theme authors have carefully
 designed for the editor. azaozz's first suggestion in [comment:8] seems
 like a much better solution, or if that doesn't work, I don't think many
 themes do things as crazy as Twenty Thirteen here, so I still think we
 could just fix it in the theme. And when those styles were added to Twenty
 Thirteen, we knew that they could potentially cause some issues down the
 road since they push the boundaries of what should be done in editor
 styles, so other themes that do similar things would probably be okay with
 adapting here.

 If we are going to keep [29543], we need to remove the corresponding
 styles from Twenty Thirteen and Fourteen as having them there implies that
 they should work in all themes, since they're bundled with core. But
 that's a big bummer for anyone who's created these styles before.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29048#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform