[wp-trac] [WordPress Trac] #28328: Focus on editing, while editing
WordPress Trac
noreply at wordpress.org
Thu Aug 14 17:47:38 UTC 2014
#28328: Focus on editing, while editing
-------------------------+-------------------------------------------------
Reporter: markjaquith | Owner:
Type: task | Status: new
(blessed) | Milestone: 4.0
Priority: high | Version:
Component: Editor | Resolution:
Severity: critical | Focuses: ui, accessibility, javascript,
Keywords: has-patch | administration
needs-testing |
-------------------------+-------------------------------------------------
Comment (by azaozz):
> ...there some new "magical numbers" that made it in
It's just one: 56. That corresponds to the pinned $tools top offset,
however we need to know it before they are pinned as the sidebar pins
first. Don't see a way to calculate that with JS. We can move it to a var,
but it is also used in the css, can probably add a comment that both
places need to be edited at the same time. The 36 is 56 - bottom margin
for the pinned sidebar.
Yep, .27.patch works well :) Thinking we may want to use `fixedBottom`
instead of `$sideSortables.outerHeight() / 2` in case the editor is quite
tall. I'll run some tests. Also looking at skipping the sidebar auto-
scroll on the first scroll down (when it gets pinned).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28328#comment:74>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list