[wp-trac] [WordPress Trac] #23560: Keyboard Accessibility of Add Media Panel

[WordPress Trac]

#23560: Keyboard Accessibility of Add Media Panel
---------------------------------------+----------------------------
 Reporter:  grahamarmfield             |       Owner:
     Type:  defect (bug)               |      Status:  reopened
 Priority:  normal                     |   Milestone:  4.0
Component:  Media                      |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |     Focuses:  accessibility
---------------------------------------+----------------------------

Comment (by celloexpressions):

 A lot of the things that we fixed here a few weeks ago have been regressed
 ([29473] fixed one). Most notably, focus is no longer set to the
 appropriate place (editing details) when selecting an attachment, which is
 the only way to get to editing details or the primary button without
 tabbing through the entire media library (including infinite scroll).

 I was going to start to break this up into individual tickets for the
 remaining unpatched items (and test & confirm as I go), but now I'm
 thinking that we may need to just punt this entirely to Future Release as
 mobile media and media grid modal work keep inadvertently breaking
 improvements made here.

 I just went through another round of testing, and '''''all'' of the issues
 listed in [comment:95] still apply'''. Additionally, I found the following
 issues:
 - Can't trigger modal-close with `esc`. I thought that was functional at
 one point, and that's one way to work around all of the lost-focus
 situations if we don't fix them in 4.0.
 - Selected attachments in toolbar don't have focus styling, making it very
 difficult to figure out where focus is when trying to get past them to the
 primary action button for the modal. This was originally fixed in [29220]
 (last hunk of media-views.css in that changeset).
 - Check/unselect icons are focusable but not actionable; pressing enter
 when the thumbnail is focussed toggles its selection, though.
 - Selected and focused attachments are not keyed to colorschemes. Selected
 but unfocused attachments display incorrectly. Selected and focused but
 not active attachments are not keyed to color schemes. See screenshot.
 This also affects non-keyboard users pretty significantly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23560#comment:97>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform