[wp-trac] [WordPress Trac] #29127: Bundled Themes: fix escaping and minor code style issues

[WordPress Trac]

#29127: Bundled Themes: fix escaping and minor code style issues
-------------------------------------+-----------------------------
 Reporter:  lancewillett             |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Bundled Theme            |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------
Changes (by obenland):

 * milestone:  4.0 => Future Release


Comment:

 Twenty Fourteen patch looks good.

 Twenty Thirteen patch:
 * Can we move the definition of `$style` to the top of the function?

 Twenty Twelve patch:
 * In `header.php`: Adding `esc_url()` around `header_image()` will not
 work, as it echoes its content.
 * Can we move the definition of `$style` to the top of the function?
 * Let's keep the new line at end of file in `inc/custom-header.php`.

 Twenty Eleven patch:
 * Do we allow HTML in the site description? If we do, using `esc_html()`
 around the site description might break things.
 * In `header.php`: Adding `esc_url()` around `header_image()` will not
 work, as it echoes its content.

 Twenty Ten patch:
 * In `category.php`: Using `esc_html()` around the category description
 might break things.
 * If we allow HTML in the site description, using `esc_html()` around the
 site description might break things.
 * In `header.php`: Adding `esc_url()` around `header_image()` will not
 work, as it echoes its content.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29127#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform