[wp-trac] [WordPress Trac] #29022: Screen reader text (and link title) isn't updated when plugin update count is updated
WordPress Trac
noreply at wordpress.org
Sun Aug 3 23:25:00 UTC 2014
#29022: Screen reader text (and link title) isn't updated when plugin update count
is updated
-------------------------+-------------------------------------------------
Reporter: pento | Owner:
Type: defect | Status: new
(bug) | Milestone: Awaiting Review
Priority: normal | Version: 3.9
Component: | Resolution:
Upgrade/Install | Focuses: accessibility, javascript,
Severity: minor | administration
Keywords: has-patch |
dev-feedback |
-------------------------+-------------------------------------------------
Comment (by pento):
This is starting to shape up nicely. Good work on finding each other at
WCNYC! :-)
I think each of the count decrement / string generation chunks could be
merged into a single loop - the code is all the same, just with different
variable names, and a special case for `wordpress` updates only having the
single string. We could also remove `reduceCount()` if its functionality
is reduced to a single use.
Now that we have the count data stored on `updatesL10n`, I think we could
also use that for the bits at the start of `decrementCount()` - it's
better to use a canonical data source than to parse a number from the
HTML.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29022#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list