[wp-trac] [WordPress Trac] #29022: Screen reader text (and link title) isn't updated when plugin update count is updated (was: Screen reader text isn't updated when plugin update count is updated)

[WordPress Trac]

#29022: Screen reader text (and link title) isn't updated when plugin update count
is updated
-------------------------+-------------------------------------------------
 Reporter:  pento        |       Owner:
     Type:  defect       |      Status:  new
  (bug)                  |   Milestone:  Awaiting Review
 Priority:  normal       |     Version:  3.9
Component:               |  Resolution:
  Upgrade/Install        |     Focuses:  accessibility, javascript,
 Severity:  minor        |  administration
 Keywords:  has-patch    |
  dev-feedback           |
-------------------------+-------------------------------------------------
Changes (by adamsilverstein):

 * keywords:  good-first-bug has-patch => has-patch dev-feedback
 * severity:  normal => minor


Comment:

 @paulschreiber thanks for working on this. your patch seemed so very close
 to working!

 its amazing how complicated it is when seeming so simple at first glance.
 I tried working with your patch and discovered, as @pento pointed out,
 that the count is cached and not updated at the point you were
 regenerating the title string.

 [attachment:29022.diff] takes a different approach, I think this is what
 pento was talking about?
  * localize the singular and plural forms of 'plugin', 'theme', and
 'translation'
  * pass the individual counts to the JavaScript as data attributes of a
 hidden span
  * decrement the appropriate count based on upgradeType
  * reconstruct the title/screen reader screen string based on these counts
 and translated words

 I think the patch works correctly, though it needs more testing. Its also
 a bit verbose with a bunch of repeated code that should be refactorable
 into something a bit more succinct. @paulschreiber since you are already
 familiar with the code here, can you take a look at the patch to improve &
 test?

 Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29022#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform