[wp-trac] [WordPress Trac] #29085: Media Grid: Remove padding and margins around left and right sides of grid

WordPress Trac noreply at wordpress.org
Fri Aug 1 23:51:48 UTC 2014


#29085: Media Grid: Remove padding and margins around left and right sides of grid
-------------------------+---------------------------------
 Reporter:  melchoyce    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.0
Component:  Media        |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:  ui, administration
-------------------------+---------------------------------

Comment (by afercia):

 hi, I agree it would look really nicer without those margins but there are
 a couple of issues :)
 About the first one, probably you don't notice anything weird because
 you're on a platform that uses "overlay scrollbars" e.g. OS X Lion+ / iOS
 / Windows 8 / Windows Phone / Android / Ubuntu Unity... but it's visible
 on other platforms for example in Windows 7- where scrollbars do occupy
 space.
 For me, the attachments UL computed width in Chrome console is 1461px but
 this.$el.width() returns 1478 I guess that's because Chrome reserves space
 for the vertical scrollbar even if overflow is "auto". This issue has been
 there even before your patch but now is really noticeable: data.columns is
 9 but I have space for just 8 columns, so the nth-of-type thing is really
 not working, see first screenshot:
 [[Image(http://i.imgur.com/xdqNVIt.jpg)]]

 Second issue: I agree the "indentation" is ugly and I did try to remove
 that margins too but unfortunately, focus style and "selected" style both
 use box-shadows that will be cut off on a side, see second screenshot:
 [[Image(http://i.imgur.com/lEim7nh.png)]]

 Please notice that at least 3 ancestor elements have an overflow value
 other than "visible" and I'm not sure they can be removed so easily.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29085#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list