[wp-trac] [WordPress Trac] #29088: Plugin_Upgrader::deactivate_plugin_before_upgrade() is hooked to a filter, but doesn't always return a value

[WordPress Trac]

#29088: Plugin_Upgrader::deactivate_plugin_before_upgrade() is hooked to a filter,
but doesn't always return a value
-----------------------------+-----------------------------
 Reporter:  jdgrimes         |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  2.8
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 `Plugin_Upgrader::deactivate_plugin_before_upgrade()` is hooked to the
 `'upgrader_pre_install'` filter by `Plugin_Upgrader::upgrade()`, but it
 doesn't always return a value. This still works because the result of the
 filter is only checked with `is_wp_error()` (in
 `WP_Upgrader::install_package()`). However, it could certainly cause bugs
 for other functions hooked to that filter.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29088>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform