[wp-trac] [WordPress Trac] #29087: Compacting non-existant variables in WP_Upgrader::install_package()

[WordPress Trac]

#29087: Compacting non-existant variables in WP_Upgrader::install_package()
-----------------------------+-----------------------------
 Reporter:  jdgrimes         |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  2.8
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 `WP_Upgrader::install_package()` calls `compact()` with a list of
 variables, some of which have never existed since this code was added in
 [11005]. This doesn't cause any problems, as non-existent variables are
 silently ignored by `compact()`, but it is quite confusing (I don't know
 what performance implications might be, but that is trivial anyway).

 The following variables don't exist:

 - `'local_source'`
 - `'source_name'`
 - `'delete_source_dir'`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29087>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform