[wp-trac] [WordPress Trac] #28042: Logic for custom header default text color is broken

WordPress Trac noreply at wordpress.org
Sun Apr 27 15:54:26 UTC 2014


#28042: Logic for custom header default text color is broken
--------------------------+-----------------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.0
Component:  Appearance    |     Version:  3.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  administration
--------------------------+-----------------------------

Comment (by ocean90):

 Replying to [comment:3 obenland]:
 > With [attachment:28042.patch] we'd still be missing a default value.

 The default value is an empty string, see [source:tags/3.9/src/wp-
 includes/theme.php#L1453]

 > Can we assume that if a theme does not provide a default color, it does
 not support changing the header color and that setting should not even
 appear?

 No. Maybe we can use a value of `false` to disable the color feature, but
 that's another ticket.

 > Or do we consider changing the color a core feature that should work
 regardless of what the theme set its default to be?

 Which is the current behavior, at least for the Customizer, but broken on
 the Custom Header screen.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28042#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list