[wp-trac] [WordPress Trac] #11338: Custom Walker initialize error

[WordPress Trac]

#11338: Custom Walker initialize error
----------------------------------------+-----------------------------
 Reporter:  ShaneF                      |       Owner:
     Type:  defect (bug)                |      Status:  reopened
 Priority:  normal                      |   Milestone:  4.0
Component:  Posts, Post Types           |     Version:  2.9
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  docs, template
----------------------------------------+-----------------------------
Changes (by DrewAPicture):

 * keywords:  good-first-bug has-patch => good-first-bug needs-patch
 * component:  General => Posts, Post Types
 * milestone:  Future Release => 4.0


Comment:

 Hi garza, thanks for the patch, this is a great start.

 Two things:
 * Where the arguments are currently listed in quotes, e.g. `'child_of`,
 they should be notated them as variables instead: `$child_of`.
 * Since the purpose of the hash notation not just to spell out what the
 default arguments are mean, but what the actual default values are, you
 also need to list the default at the end of the descriptions and also the
 values they accept only certain values are accepted.

 Take a look at the [source:trunk/src/wp-includes/post.php#L2874 PHPDoc
 block for wp_insert_post] to see what I mean. Thanks again!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/11338#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform