[wp-trac] [WordPress Trac] #18909: Bundled jQuery UI should have CSS

WordPress Trac noreply at wordpress.org
Tue Apr 22 18:28:13 UTC 2014


#18909: Bundled jQuery UI should have CSS
--------------------------------+-----------------------------
 Reporter:  helen               |       Owner:
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  Future Release
Component:  External Libraries  |     Version:  3.3
 Severity:  normal              |  Resolution:
 Keywords:  needs-patch         |     Focuses:  ui
--------------------------------+-----------------------------
Changes (by helen):

 * keywords:  has-patch => needs-patch


Comment:

 Replying to [comment:85 jaredatch]:
 > Over the past few years there have been some fairly solid patches and
 suggestions.
 >
 > What do we need to move this forward.

 1. Needs to match the current admin and be complete across all enqueuable
 jQuery UI components - what's in my old GitHub repo is now outdated, and
 just the datepicker isn't enough. I don't see any patches or other
 stylesheets out there that meet this requirement, which is the most
 important one. I've seen one or two that come close visually, but are not
 quite right.
 2. Needs to at least take into account people who are currently enqueueing
 their own styles or the old `wp-jquery-ui-dialog` stylesheet - likely we
 need to use a scoping class or similar, but that does introduce complexity
 for developers to implement.
 3. Needs to take color schemes and generation into account. It's possible
 it might be fine to just put jQuery UI rules into the color scheme files
 and have them load all the time, but be aware of cascade problems.
 4. A comprehensive test page so that this can be tested well, now and in
 the future. There is one that comes with jQuery UI, but it's not
 comprehensive.
 5. At least some acknowledgment of what it means to maintain this moving
 forward.

 Also note that Iris (the color picker) and revisions both use jQuery UI
 slider, and several other places in the admin use other components, like
 sortable and autocomplete.

 Patches can iterate - a first patch doesn't need to address all of this at
 once by any means. But I don't want anybody to feel like they didn't see
 something coming. There's a lot going on, and backcompat is an important
 consideration, even in CSS. I don't mind causing some visual breakage, but
 only if we do our due diligence.

 I have a feeling avryl might be into running with this - pinged her for
 good measure :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18909#comment:86>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list