[wp-trac] [WordPress Trac] #27853: The "admin_footer" action isn't called on customize.php

WordPress Trac noreply at wordpress.org
Mon Apr 21 09:09:56 UTC 2014


#27853: The "admin_footer" action isn't called on customize.php
-----------------------------+--------------------
 Reporter:  feedmeastraycat  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.9.1
Component:  Editor           |     Version:  3.9
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+--------------------

Comment (by feedmeastraycat):

 My patch fixes my issues. And I assume a patch on wp_editor that changes
 the actions to this:
 {{{
 #!php
 if ( empty(self::$first_init) ) {
         if ( is_admin() ) {
                 add_action( 'admin_print_footer_scripts', array(
 __CLASS__, 'enqueue_scripts'), 1 );
                 add_action( 'admin_print_footer_scripts', array(
 __CLASS__, 'editor_js'), 50 );
         } else {
                 add_action( 'wp_print_footer_scripts', array( __CLASS__,
 'enqueue_scripts'), 1 );
                 add_action( 'wp_print_footer_scripts', array( __CLASS__,
 'editor_js'), 50 );
         }
 }
 }}}
 Would fix it as well. The important part is that
 `_WP_Editor::enqueue_scripts()` is never called on customize.php. Both my
 submitted patch and the example above should fix that.

 I can create a patch like that and test it. And if it seems to fix the
 issue I'll submit it.

 But the big thing here ''(I guess)'' is that I don't know if any of these
 patches will have bad side effects elsewhere. :)

 But maybe there is a third, easier and better way?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27853#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list