[wp-trac] [WordPress Trac] #27359: Color Picker Missing From WordPress 3.9
WordPress Trac
noreply at wordpress.org
Sun Apr 20 20:37:15 UTC 2014
#27359: Color Picker Missing From WordPress 3.9
---------------------------+-----------------------------
Reporter: hardeepasrani | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: TinyMCE | Version: 3.9
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
---------------------------+-----------------------------
Comment (by avryl):
> Thinking the "live preview" inside the editor while selecting a
color/dragging the handle is not needed. The text where the color is going
to be applied is usually selected at this tile. That makes the "live
preview" invisible. It also seems to make dragging of the handle to lag.
If you decide to keep it, it will need to be wrapped in
editor.undoManager.transact() so it doesn't add new undo level on every
color change.
Good point, completely forgot about the undoManager. Together with your
first point, it would make sense to remove the "preview" and apply the
colour after selecting one.
> The tiny "color bar" under the icon in the button is intended to keep
the last selected color value and apply it on clicking the button. It
shouldn't change according to the current node's color.
I've always found that confusing. When you put your cursor in a coloured
node, I expect the colour to change. Right now putting your cursor in a
coloured node updates the "saved colour", which you can then apply to
uncoloured text. That way you can actually quickly switch between already
used colours.
> The CSS selectors need to be more specific so they don't override other
instances of Iris.
Okay. :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27359#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list